New error message when viewing the home page

[bekateen]

Hi Jools,

When I visit PCF, I'm seeing this error message at the top of the page.

Cheers, Eric

[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/common/functions/_articles.php on line 421: Undefined variable $old_part
[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/common/functions/_articles.php on line 453: Undefined variable $part_text
[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/index.php on line 135: Undefined variable $meta
[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/index.php on line 135: Undefined variable $breadcrumbs
[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/common/functions/arn_make_page.php on line 43: Undefined array key "species"
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)
[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/common/functions/arn_make_page.php on line 47: Undefined variable $phpbb_root_path

[Jools]

These are "undefined variable" errors - they won't break anything but will be a few of them still lurking around.

This is due to a background upgrade to the operating system on our server. I've been holding off for a better time, but it seems now I can't delay this any longer.

I will fix as I find them or reported here.


Jools

[bekateen]

Makes sense. Agreed it doesn't impair my ability to engage the site so far.

Cheers,
Eric

[Ltygress]

They're all over the place. I see a TON of them when I visit the L-numbers catalog.

[Shovelnose]

Faced this issue sporadically with the home page the past few days, it now occurs every time with genus and species pages.

[Jools]

There are indeed loads of warning error messages, most are quite easy to fix in a couple of minutes, but a few are several hours to sort out. Each line is one error but they can be "duplicates" i.e. if a page has a pH dropdown on it, and I fix that error, all pages with that pH dropdown will be fixed.

Up to now I have focussed on the front page, some key admin features, the forum and now the species profiles which looked to be clear.

Will do the genus and then l-number pages next.

Cheers,

Jools

PS On the plus side, these errors point out where I have written code that usually works or might not now work as intended. In fixing them up I have found some old stuff no longer needed, one security vulnerability and one bit that just plain didn't work. Now the size data in the catelog is served up in mm or inches depending on your user profile data, if not set it asked you to do this and if not logged in (or a bot) it serves up both mm and inches. That's not worked in years, maybe ever.

Once the changes are made, dropdown lists (over 20 year old code!!!) in particular may be susceptible to new bugs.

[bekateen]

Up to now I have focussed on the front page, some key admin features, the forum and now the species profiles which looked to be clear.

Cheers,

Jools

Thanks for all the work.

To make sure I understand, are you saying the front page and species (CLOG) pages are finished?

I see this error on the front page:

[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/common/functions/latest_donations.php on line 14: Undefined variable $no
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)

I'm still getting this error when I visit a clog page:

[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/common/functions/_articles.php on line 491: Undefined variable $text
[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/common/functions/species_datasheet.php on line 205: Undefined array key ""
[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/common/functions/species_datasheet.php on line 205: Trying to access array offset on value of type null
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)

Cheers, Eric

[Jools]

These ones will be becuase the data on the page is different from what I checked. Which species was it?

Cheers,

Jools

[bekateen]

Thanks for all the work.

I'm still getting this error when I visit a clog page:

[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/common/functions/_articles.php on line 491: Undefined variable $text
[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/common/functions/species_datasheet.php on line 205: Undefined array key ""
[phpBB Debug] PHP Warning: in file /home/webcat/planetcatfish.com/common/functions/species_datasheet.php on line 205: Trying to access array offset on value of type null
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)
[phpBB Debug] PHP Warning: in file [ROOT]/includes/functions.php on line 4191: Cannot modify header information - headers already sent by (output started at [ROOT]/includes/functions.php:3032)

Cheers, Eric

These ones will be becuase the data on the page is different from what I checked. Which species was it?

Cheers,

Jools

Hypostomus sp(l229)

Cheers, Eric

[Jools]

That should be the background warning messages fixed in the family, sub-family and genus pages.

Jools

[Jools]

The "all genera" page has been fixed, and updated.


Jools

[Jools]

The "IBAMA positive list" page has been fixed.

[Jools]

The "Catfish IUCN Red List" page has been fixed.

Jools

[Jools]

The list of species kept, bred, wished for and seen page has been fixed. Bonus new feature, the My Cats list shows the longest kept.

Cheers,

Jools

[Jools]

Updated the List of species with no pictures page.

Jools

[bekateen]

Updated the List of species with no pictures page.

Jools

I had no idea this page existed.

[Jools]

Now you do! A few candidates in there for re-assignment!

Today I have made all the "My Aquaria" stuff work without error/warning messages.

Cheers,

Jools

[Jools]

On the species profile pages, there is a new link to the My Cats food data in the feeding data section. This has been in development for a while, and I never quite finished it and it was riddled with warning errors. While it is rudimentary, it works, now error-free, and I've added it in.

Registered keepers, spots and wishes pages next.

Cheers,

Jools

[Jools]

All book reviews, Shane's world and CotM pages should now work with errors. I've also checked most of the "recent updates of" pages too. I think this (big, hairy) monkey will be off my back in the next week or so.

Cheers,

Jools

[Jools]

Over the past week, I've reviewed every other Planet page and removed these warning messages/bugs. I may have missed some but I think, generally, this issue is fixed. It has highlighted several areas of improvement and I found a bunch of old bugs or things that have just plain never worked and now do.

Anyway, closing this one off, if you spot anything else, not already reported, please post a new topic!

Thanks to everyone for your patience while I sorted this out; it was epic!


Cheers,



Jools