Add new or undescribed species function is broken

[bekateen]

Hi Jools,

Today I tried to add the new Microcambeva bendego to the CLOG. When I submitted the name I received the message "name not found" and a recommendation that I try adding new species (in other words, it circled me back to where I started).

Sorry,
Eric

[bekateen]

Hi Jools,

I can tell you're making progress. Today I tried it again (as a lark) and obtained this error:

Fatal error: Uncaught Error: Call to undefined function get_family_from_id() in /home/webcat/planetcatfish.com/admin/functions/add_species.php:53 Stack trace: #0 /home/webcat/planetcatfish.com/admin/classes/add_new_species.php(61): add_species('microglanis aff...', false, NULL) #1 /home/webcat/planetcatfish.com/admin/index.php(352): add_new_species->submit(Object(phpbb\db\driver\factory)) #2 /home/webcat/planetcatfish.com/admin/index.php(298): arn_admin_guts('ans', Object(phpbb\db\driver\factory), Object(phpbb\user), '5.2.1') #3 {main} thrown in /home/webcat/planetcatfish.com/admin/functions/add_species.php on line 53

Cheers, Eric

[Jools]

Hi Eric,

Thanks for noticing. It's a one of those "I can't deliver the spare part to fix the machine because the road is broken" type problems. I made a significant change in the background to how new species are created. So, now, you can't create a new species if that taxon exists as a synonym anywhere (e.g. in another family or even order) however, the code is so complex I basically need to rewrite it. This process is called refactoring and I do a lot of it! The basic "add a new species" code was written around 2005, by me, so it's not that brilliant and has a lot of duplication and non-standard bits in it.

I hope to get this up and running in a matter of days.

Cheers,

Jools

[bekateen]

Hi Jools.

This function is working for me. If you're finished recoding it, I'd think it's resolved.

Thanks, Eric