Question about most kept species

[Marc van Arc]

See title; wrt Auchenipteridae.

How come that the 25 most kept species include species that no-one keeps, like

Pseudauchenipterus nodosus

and

Ageneiosus rondoni

?

[Dave Rinaldo]

For reference to others, the list Mark refereed to can be found here.
Auchenipteridae

[MatsP]

Hmm, I don't understand what's going on here.

I will have a look at the code when I have time.

Edit: Just scanned through the code, and the "title" of the section seem to not be the same as what it actually shows: It shows the most "hit" species (as in the species with most peiople viewing the page), not the ones with the most keepers.

@Jools: Do we want to "make this do what is says on the label" or "change the label to reflect the content"?

--
Mats

[MatsP]

I have changed the code for this, and it's online, but still a bit broken, since the "percentage" number is calculated incorrectly (I wrote this "blind", as I was visiting Sweden and my local copy of PC is on my home machine, and I'd forgotten a configuration step when upgrading recently, so I could not test it before giving it to Jools for upload to the site).

I will try to fix the percentage calculation over the next few days, but have extra water changes due to being away...

--
Mats

[dpm1]

Wow...my woodcats dont even come under the most common family listing let alone top species!...better take more care of them...(actually only 6 keepers and little info anywhere so this isn't a surprise and far from likely error)

However the % on species is also wrong elsewhere
Eg Callichthyidae (no wonder I usually stick to 'Corys et al') (and a couple others I looked at


#1 C. Pygmaeus
#2 C. Habrosus (I know I have both but surely I don't swing the vote that much!)
#3 C.Julii - probably skewed anyway as 99% are trilineatus (again I've had both)
#11 C. Aeneus...bronze down at 11...would expect 1 or 2.
...and no place in the top 25 for C. paleautus everyone's favourite dumb as a bag of spanner peppered.

Just thought I would point it out as my unusual, though certainly not exactly rare, seem to have exploded in popularity... ...whilst my BN is no longer 'common'...

[MatsP]

Ok, so should point out that it's (so far) only the subfamily pages that have the NEW code. The family pages don't.

--
Mats

[MatsP]

And two sets of changes should make this work for family and the percentage calculation of "what percantage keeps this species" in the subfamily.

Changes are R1550 (percentage in subfamily, and some other tidy up), R1551 (same changes as in subfamily but for the family.php).

--
Mats

[MatsP]

Just found an interesting feature, however. If two species has the exact same number of keepers, only one is being displayed.... ;)

Probably need to come up with a better way to maintain a "most kept" list. Will try to do this today.

--
Mats

[MatsP]

R1552-1553 has an updated version that copes with "more than one species has the same number of keepers".

--
Mats

[Jools]

The update is now in place.

Jools

[MatsP]

So, Marc: Does this show what you expect, now?

--
Mats

[Jools]

Closed - think this all works fine.

Jools