My Cats Email Links Fail on iPhone

[Martin S]

Hi
I received an email today listing all the cats I keep and asking to specify edits, no change or stop keeping. But if I click on the no change link I get the attached error:

Should I do this on the PC?

Not a bug, but a related question - this also made me wonder about how I can record updates in size - I'm waiting on a new tank and will plan to catch, photograph and measure each fish to see how they have grown - is there any way to record this apart from notes?

Thanks
Martin

[Jools]

Hmmm, that's interesting. Can you forward the email to me (webmaster at planetcatfish dot com)?

Somewhere on it's journey through cyberspace, the space character between the n and the S in your username has gone missing.

Will look into it...

Cheers,

Jools

[Jools]

Oh, and on the size thing, when editing my cats you can update the sizes...

Jools

[Martin S]

Hmmm, that's interesting. Can you forward the email to me (webmaster at planetcatfish dot com)?

Somewhere on it's journey through cyberspace, the space character between the n and the S in your username has gone missing.

Will look into it...

Cheers,

Jools

Will do.

Oh, and on the size thing, when editing my cats you can update the sizes...

OK thanks - I guess I was just considering being able to see the growth rate since adding - maybe I'll jot the before and after down as I add.

Thanks again

Martin

[Jools]

This is just a note to myself, so apologies for the techno mumbo-jumbo.

Code: Select all

<br /><img class='dropshadow' src='http://www.planetcatfish.com/images/thumb(l)/doradidae/hassar/orestis/1.jpg' title='Hassar orestis' alt='Hassar orestis' /><br /><em>Hassar</em> <em>orestis</em> - <a href='http://www.planetcatfish.com/common/my_fish.php?task=edit&id=32685&species_id=39&username=Martin S'>edit</a>, <a href='http://www.planetcatfish.com/common/my_fish.php?task=touch&id=32685&species_id=39&username=Martin S'>no change</a> or <a href='http://www.planetcatfish.com/common/my_fish.php?task=edit&edmode=stop&id=32685&species_id=39&username=Martin S'>stop keeping</a>. Last update: 2012-10-05.

The issue is the "Martin S" in the URL, it should be encoded to Martin%20S to allow it to pass correctly through all mail transports. It's going to be a "good one" to test, will need to put some time aside to test properly as getting this wrong could break a LOT of emails.

At least you know it's a bug!

Jools

[MatsP]

Do we have, or is there a "ready-made" PHP function for converting spaces to "%20" like this? I seem to remember we've had a similar thing before now.

Edit: Answer to myself:

Code: Select all

rawurlencode

should do what is needed here.

--
Mats

[Jools]

This is now fixed. Martin, would appreciate confirmation next time you get the chance, or anyone else with a space in their username (e.g. @Dave Rinaldo) ?

Cheers,

Jools